From 3bc44f85de340c8da88d74b561b75716162d84d0 Mon Sep 17 00:00:00 2001 From: Johnny Richard Date: Sat, 29 Apr 2023 20:49:51 +0200 Subject: ast: Remove ast visitor pattern to simplify the code I decided to remove the visitor pattern due to the lack of Object Oriented Programming support for C. Now if you want to navigate through the AST, you should do it with switch case and recursion. The code looks way simpler without visitor pattern. I have added a CFLAG -Werror which validates if the switch statement covers all branches for a given enum at compile time. Signed-off-by: Johnny Richard --- src/ast.h | 15 --------------- 1 file changed, 15 deletions(-) (limited to 'src/ast.h') diff --git a/src/ast.h b/src/ast.h index 267e8ba..1f0da13 100644 --- a/src/ast.h +++ b/src/ast.h @@ -20,14 +20,11 @@ #include "vector.h" #include -#define ast_visitor_visit(visitor, node) ast_node_accept_visitor(node, (ast_visitor_t *)visitor); - typedef enum { TYPE_I32 } type_t; -typedef struct ast_visitor_t ast_visitor_t; typedef struct ast_node_t ast_node_t; typedef struct ast_return_stmt_t @@ -85,14 +82,6 @@ typedef struct ast_variable_declaration_t ast_node_t *value; } ast_variable_declaration_t; -typedef struct ast_visitor_t -{ - void (*visit_function)(struct ast_visitor_t *, ast_function_declaration_t *); - void (*visit_return_stmt)(struct ast_visitor_t *, ast_return_stmt_t *); - void (*visit_literal)(struct ast_visitor_t *, ast_literal_t *); - void (*visit_binary_operation)(struct ast_visitor_t *, ast_binary_operation_t *); -} ast_visitor_t; - typedef enum { AST_BINARY_OPERATION, @@ -116,14 +105,10 @@ typedef union typedef struct ast_node_t { - void (*accept_visitor)(ast_node_t *, ast_visitor_t *); ast_node_kind_t kind; ast_node_data_t data; } ast_node_t; -void -ast_node_accept_visitor(ast_node_t *node, ast_visitor_t *visitor); - ast_node_t * ast_node_new(); void -- cgit v1.2.3